Refactor postgresql migration #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh24
changed the title
ssh24
force-pushed
the
refactor-postgresql-migration
branch
6 times, most recently
from
320aa34 to
6f79234
Compare
jannyHou
reviewed
Mar 1, 2017
lib/migration.js
Outdated
| } | ||
| if (!err) { | ||
| data.forEach(function(field) { | ||
| field.type = mapPostgreSQLDatatypes(field.type, field.length); |
There was a problem hiding this comment.
mapPostgreSQLDatatypes is missing after refactor
ssh24
force-pushed
the
refactor-postgresql-migration
branch
from
7ad2413 to
760e761
Compare
jannyHou
reviewed
Mar 1, 2017
| * @param {String} property The property name | ||
| * @returns {String} The column type | ||
| */ | ||
| PostgreSQL.prototype.columnDataType = function(model, property) { |
There was a problem hiding this comment.
Hmm, why changing this function from columnDataType to buildColumnType?
we need both of them.
There was a problem hiding this comment.
Moved columnDataType to base connector loopbackio/loopback-connector@752359f
We still have buildColumnType in postgresql
ssh24
changed the title
|
@slnode test please |
ssh24
force-pushed
the
refactor-postgresql-migration
branch
from
760e761 to
15c20ae
Compare
Extract getTableStatus & autoupdate Extract isActual function Extract getDropColumns into base connector Extract addPropertyToActual to base connector Extract searchForPropertyInActual to base Extract propertyHasNotBeenDeleted to base Extract applySqlChanges to base Extract columnDataType to base connector Use mapPostgreSQLDatatypes in showFields
ssh24
force-pushed
the
refactor-postgresql-migration
branch
from
15c20ae to
d6b1504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor discovery test cases
Related issues
connect to loopbackio/loopback-connector#15